fix: adding missing "" to PublicPath and browser.runtime.getUrl.#1597
Merged
aklinker1 merged 3 commits intowxt-dev:mainfrom Apr 24, 2025
Merged
fix: adding missing "" to PublicPath and browser.runtime.getUrl.#1597aklinker1 merged 3 commits intowxt-dev:mainfrom
aklinker1 merged 3 commits intowxt-dev:mainfrom
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aklinker1
reviewed
Apr 21, 2025
Member
aklinker1
left a comment
aklinker1
left a comment
There was a problem hiding this comment.
Should it go first? I purposefully put "/" first so IDEs show it at the top. "" should probably go above it?
Contributor
Author
@aklinker1 Updated. |
Timeraa
approved these changes
Apr 21, 2025
aklinker1
approved these changes
Apr 21, 2025
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Contributor
|
Thanks for helping make WXT better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
for public path
""was missingbasically
browser.runtime.getUrl("")command is throwing type error.I guess something was updated in this function
getPathsDeclarationEntrywhich broke that.when running
pnpm compileit also throws error.Manual Testing
browser.runtime.getUrl("")in background.ts file (you'll see the type error).pnpm compile